Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build for legacy platforms by disabling ECC on .NET 4.6.2 & NET-Standard2.0 #2811

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix build for legacy platforms by disabling ECC on .NET 4.6.2 & NET-Standard2.0 #2811

merged 3 commits into from
Oct 24, 2024

Conversation

romanett
Copy link
Contributor

Proposed changes

After merging ECC build for legacy platforms (.NET 4.6.2 & NetStandard2.0) was broken. This PR fixes the build for legacy platforms

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett requested a review from mrsuciu October 23, 2024 16:53
@romanett romanett changed the title fix build for legacy platforms by disabling ECC fix build for legacy platforms by disabling ECC on .NET 4.6.2 & NET-Standard2.0 Oct 23, 2024
@romanett romanett marked this pull request as draft October 23, 2024 17:13
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (f433fa4) to head (815e5c0).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2811      +/-   ##
==========================================
- Coverage   55.64%   55.30%   -0.34%     
==========================================
  Files         352      352              
  Lines       67326    67332       +6     
  Branches    13806    13806              
==========================================
- Hits        37464    37239     -225     
- Misses      25825    26009     +184     
- Partials     4037     4084      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett marked this pull request as ready for review October 24, 2024 05:27
@mregen mregen merged commit 0c6b38b into OPCFoundation:master Oct 24, 2024
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen mregen approved these changes

@mrsuciu mrsuciu Awaiting requested review from mrsuciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanett @mregen